[Bug 684407] Review Request: perl-Monotone-AutomateStdio - Perl interface to Monotone via automate stdio

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 31 13:01:19 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=684407

--- Comment #2 from Thomas Moschny <thomas.moschny at gmx.de> 2011-03-31 09:01:18 EDT ---
(In reply to comment #1)
> I have few comments on packaging.
> Shouldn't be mtn-tester also installed or run as test?

>From the README:

 "Please note that automated testing of this library module is still `work in
  progress'. There is a test harness called mtn-tester that can be used to test
  most important features of this library. However, it does require not only
the
  installation of Monotone, as you would expect, but also a test database with
  certain revisions and files in it. At the moment this is done by using a
  dedicated branch in the main Monotone database found at monotone.ca. The test
  branch is called net.venge.monotone.contrib.lib.automate-stdio.test.

  In time I hope to write a Monotone emulator that generates the required
output
  to test the library, or perhaps just have a smaller database generated on the
  fly."

So I'd say mtn-tester should neither be run nor installed.

In theory, I could create a Monotone database with that branch in it and
include it in the package, and generate a temporary key on the fly, but that's
a lot of effort for little gain.

> Also upstream created strange pod file. Usually are pods created from pm files,

In what way is it "strange"?

What do you suggest? I could talk to upstream and ask him to include the docs
in the .pm and generate the .pod from that.

> but that's not blocker.
> NOT APPROVED

So, what is the blocker then?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list