[Bug 522821] Review Request: bluetile - A modern tiling window manager with a gentle learning curve

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 31 14:16:48 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=522821

Lakshmi Narasimhan <lakshminaras2002 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

Bug 522821 depends on bug 634052, which changed state.

Bug 634052 Summary: Review Request: ghc-ConfigFile - configuration file library for Haskell
https://bugzilla.redhat.com/show_bug.cgi?id=634052

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED
             Status|MODIFIED                    |ON_QA
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

--- Comment #21 from Lakshmi Narasimhan <lakshminaras2002 at gmail.com> 2011-03-31 10:16:43 EDT ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.

rpmlint  -i *.rpm ../bluetile.spec
bluetile.x86_64: W: no-manual-page-for-binary bluetile
Each executable in standard binary directories should have a man page.

bluetile.x86_64: W: no-manual-page-for-binary gnome-bluetile-session
Each executable in standard binary directories should have a man page.

2 packages and 1 specfiles checked; 0 errors, 2 warnings.

[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Naming-Yes
        Version-release - Matches
        License - OK, BSD 3 clause variant
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - Used to store three files used by bluetile executable
        rpmlint - OK
        changelogs - OK
        Source url tag  - OK, validated.
        Buildroot is ignored - Not present
        %clean is ignored - Not present
        Build Requires list - OK
        Summary and description - OK
        API documentation - None, it is an executable package.

[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
Licensed with BSD 3clause variant license.

[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
LICENSE file is included in /usr/share/doc/bluetile-{ver} folder

[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.

md5sum bluetile-0.5.3.tar.gz 
6c3aecd280640f8435a8400e102cae95  bluetile-0.5.3.tar.gz

md5sum built/bluetile-0.5.3-2.fc15.src/bluetile-0.5.3.tar.gz 
6c3aecd280640f8435a8400e102cae95 
built/bluetile-0.5.3-2.fc15.src/bluetile-0.5.3.tar.gz

[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on x86_64.

[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
[NA]MUST: Packages stores shared library files must call ldconfig in %post and
%postun.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides.
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissable content.
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[NA]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix
(e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must
go in a -devel package.
[NA]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
[NA]MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[-]MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section
desktop-file-install is not being used.
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Installs fine. I am able to see bluetile option in gnome display manager. Once
started, I see the dock panel to the left and a welcome dialog. When I click on
the open windows button, two more windows are opened. 
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.


cabal2spec-diff is OK.

Issues:
As per packaging guidelines, desktop-file-install is to be used for the
.desktop file. I feel that since we do not display the menu item in the menu,
not using desktop-file-install should be fine.

I clicked on the "Configure bluetile" button. I got a dialog to configure the
file manager. I set it to nautilus and closed the dialog. When  I clicked on
the button again, I got an "Input/Output error".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list