[Bug 226510] Merge Review: udev

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226510

--- Comment #20 from Jon Ciesla <limb at jcomserv.net> 2011-03-31 13:20:21 EDT ---
Cool, thanks!

Starting over on current rawhide SRPM:

udev.src:182: W: mixed-use-of-spaces-and-tabs (spaces: line 129, tab: line 182)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

udev.src: W: invalid-url Source0:
ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/udev-167.tar.bz2 <urlopen
error ftp error: [Errno 111] Connection refused>
The value should be a valid, public HTTP, HTTPS, or FTP URL.

These are the only things not addressed above.

These are new, and I'm imagining are ok:

udev.i686: W: devel-file-in-non-devel-package /usr/share/pkgconfig/udev.pc
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

udev.i686: W: cross-directory-hard-link /etc/udev/makedev.d /var/lib/udev
File is hard linked across directories.  This can cause problems in
installations where the directories are located on different devices.

udev.i686: W: no-manual-page-for-binary start_udev
Each executable in standard binary directories should have a man page.


Otherwise, it looks good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.