[Bug 676129] Review Request: qconf - Allows you to have a nice configure script for your qmake-based project

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676129

--- Comment #16 from Michal Schmidt <mschmidt at redhat.com> 2011-03-31 14:01:20 EDT ---
Well, I don't think you need to copy Kevin's fragment exactly. I linked it to
provide inspiration. For instance, I don't think you really need to add
-Wno-non-virtual-dtor. And there's no pkg-config usage in this project, so I
don't see any value in PKGCONFIG_CFLAGS either.

And did you really need to switch to calling qmake-qt4 instead of ./configure?
I believe that when the patch is applied, this should work fine:
CXXFLAGS="%{optflags}" ./configure --prefix...
But I do not really understand what difference it makes, so if you think
calling qmake-qt4 is better, that's fine with me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.