[Bug 691541] Review Request: icedtea-web - Additional Java components for OpenJDK

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691541

--- Comment #6 from Deepak Bhole <dbhole at redhat.com> 2011-03-31 15:53:40 EDT ---
(In reply to comment #3)
> Thanks for the fixes. Some more minor issues.
> 
> - archbuild, archinstall: are these macros used anywhere? Or is this some
> rpm-internal magic?
> 

archbuild was used in an older version of the spec file, not any more though.
I've removed it. archinstall is used in the %install section of the spec file.

> - Why is the main package exclusive arch? Is it because openjdk is exclusive
> arch?
> 

Yes. I've added a comment stating so now.

> - Javadoc subpackage needs to be built as noarch [1]. Since it does not depend
> on the main package, it needs its own copy of COPYING [2].
> 

Fixed.

> - %files javadoc uses %{datadir}/javadoc but configure uses %{_javadocdir}
> 

Fixed.

New spec file and srpm attached.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.