[Bug 688183] Review Request: iceplayer - A simple music player for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=688183

--- Comment #12 from Michael Schwendt <mschwendt at gmail.com> 2011-05-03 04:24:02 EDT ---
Just a quick look at the spec file:

So, if the base "iceplayer" package requires "iceplayer-data" and
"iceplayer-data" requires" iceplayer", you've created a circular dependency
within the packages built from the same src.rpm. Since iceplayer-data is not
noarch, why put the data into a separate package instead of the base package?


> Requires:	%{name}-data gstreamer

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

In particular, the dependency on GStreamer libraries should be automatic
already. However, is a dependency on a minimum set of GStreamer Plug-in
packages missing?


> %files		data
> %defattr (-,root,root,-)
> %{_datadir}/%{name}/*

https://fedoraproject.org/wiki/Packaging:UnownedDirectories

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.