[Bug 701785] Review Request: puzzle-master - Fun and addictive jigsaw puzzle game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701785

--- Comment #2 from William Lima <wlima at primate.com.br> 2011-05-03 22:09:25 EDT ---
Rpmlint output

[will at totoro rpmbuild]$ rpmlint SRPMS/puzzle-master-1.2.2-1.fc15.src.rpm 
puzzle-master.src: W: file-size-mismatch puzzle-master-1.2.2.tar.gz = 762626,
http://venemo.fedorapeople.org/sources/puzzle-master-1.2.2.tar.gz = 762620
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

You should document how to generate the tarball instead of linking to the
file on fedorapeople.

http://fedoraproject.org/wiki/Packaging/SourceURL

[will at totoro rpmbuild]$ rpmlint
RPMS/x86_64/puzzle-master-1.2.2-1.fc15.x86_64.rpm 
puzzle-master.x86_64: E: script-without-shebang
/usr/share/applications/puzzle-master.desktop
puzzle-master.x86_64: W: no-manual-page-for-binary puzzle-master
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

[will at totoro rpmbuild]$ rpmlint puzzle-master
puzzle-master.x86_64: E: script-without-shebang
/usr/share/applications/puzzle-master.desktop
puzzle-master.x86_64: W: no-manual-page-for-binary puzzle-master
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

Looking at source, puzzle-master.desktop is executable.

The permission can be fixed with %attr:

%attr(644,root,root) %{_datadir}/applications/puzzle-master.desktop

other files have wrong permissions too, like png images.

Also check desktop-file-install usage:

http://fedoraproject.org/wiki/Packaging/Guidelines#desktop

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.