[Bug 701785] Review Request: puzzle-master - Fun and addictive jigsaw puzzle game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701785

--- Comment #4 from Timur Kristóf <timur at sch.bme.hu> 2011-05-04 08:04:29 EDT ---
(In reply to comment #2) 
> You should document how to generate the tarball instead of linking to the
> file on fedorapeople.

The upstream author (which happens to be myself) puts the released tarball onto
Fedorapeople. So I see nothing wrong with that.
If you insist on the git instructions instead, I could of course include them
in the .spec.

> Looking at source, puzzle-master.desktop is executable.
> 
> The permission can be fixed with %attr:
> 
> %attr(644,root,root) %{_datadir}/applications/puzzle-master.desktop

Thanks, I fixed the permissions for both the .desktop and the icon file.

> other files have wrong permissions too, like png images.

Only the icon file (puzzle-master.png) is relevant, the others are not in the
package. (They are embedded into the executable by Qt.)

> Also check desktop-file-install usage:
> 
> http://fedoraproject.org/wiki/Packaging/Guidelines#desktop

Okay, I added desktop-file-validate to my .spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.