[Bug 701112] Review Request: mingw32-wxWidgets - C++ cross-platform GUI library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701112

--- Comment #4 from Kalev Lember <kalev at smartlink.ee> 2011-05-05 15:39:22 EDT ---
Fedora review mingw32-wxWidgets-2.8.12-1.fc14.src.rpm 2011-05-05

+ OK
! needs attention

+ rpmlint output
+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the package base name
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
  native Fedora package
! The package doesn't contain the license file 
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  2fa39da14bc06ea86fe902579fedc5b1  wxWidgets-2.8.12.tar.gz
  2fa39da14bc06ea86fe902579fedc5b1  Download/wxWidgets-2.8.12.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
    Fedora MinGW guidelines allow headers in main package
+ Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
    Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8


Issues:
! The binary rpm doesn't contain any license files, although they are 
  shipped in the upstream tarball.

Can you also move the _mingw32_debug_package macro so it'd be right before the
%prep section? This is far from a blocker, but the way it currently is breaks
'spectool -g'.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.