[Bug 696485] Review Request: django-countries - Provides a country field for Django models

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=696485

Arun SAG <sagarun at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #3 from Arun SAG <sagarun at gmail.com> 2011-05-08 13:18:21 EDT ---
Rahul,

I got that trick from
http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Zero_length_files

You are correct __init__ files in python packages can be empty, if we remove
those files that will screw up the package.

On the other hand, If the upstream chooses to have some code inside models.py
in future (unlikely), you _might_ accidentally end up deleting it :-) 


complete review:

+ = OK
- = NA
? = issue


+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.

+ Sources match upstream md5sum
b3c0ac13c382ac41bff786231dc20e79 
/home/zer0c00l/rpmbuild/SOURCES/django-countries-1.0.5.tar.gz


- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.


+ Package compiles and builds on at least one arch.
http://koji.fedoraproject.org/koji/taskinfo?taskID=3058140

+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.

- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line.  I also remove the rpmlib junk and
anything provided by glibc.)

SHOULD Items:

+ Should build in mock.
+ Should build on all supported archs
+ Should function as described.
+ Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)


Package tested and working fine with Django-1.2.5
===================================================
In [2]: from users import models

In [3]from users.models import Person

In [4]:person = Person(name='Arun',country='IN')

In [5]: person.country
Out[5]: Country(code=u'IN')

In [6]: person.country.flag
Out[6]: u'/flags/in.gif'

=====================================================


XXXXXXXXXX APPROVED XXXXXXXXXXXXXXXXXXX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.