[Bug 702957] Review Request: pclock - WindowMaker dockapp which displays an analog clock

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702957

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de> 2011-05-09 03:32:47 EDT ---
Mario, here are some notes on your package:

- Remove the empty folder %{_datadir}/%{name}-%{version}/src from the package.

- I suggest to move the examples to %{_datadir}/%{name}. The version number is
  not required here. 

- You probably also want to patch the start scripts with the correct path to 
  the pclock binary. Currently, they don't work.

- The app only works properly on my system if switch -w is given. Otherwise, I
  get a black window. Maybe -w should also be added to the start scripts.

- Drop the asterisk from %{_datadir}/%{name}-%{version}/* for proper directory
  ownership.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.