[Bug 701866] Review Request: php-pecl-yaml - Support for YAML 1.1 serialization using the LibYAML library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701866

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com
               Flag|                            |fedora-review?

--- Comment #1 from Remi Collet <fedora at famillecollet.com> 2011-05-12 10:31:00 EDT ---
I will do the review (and can sponsor you, I will contact you by mail about
what I'm waiting for)

Quick notes:

- should requires php-devel >= 5.2.0  (according to upstream)
- php_apiver macro is not used
- is your patch reported upstream ?
- upstream provides a test suite which should be run during %check
- More comments in the provided .ini could be usefull (documentation purpose)


====== for test suite
%check
cd %{pecl_name}-%{version}
make test NO_INTERACTION=1 | tee ../rpmtests.log
if grep -q "FAILED TEST" ../rpmtests.log; then
  exit 1
fi


===== for yaml.ini
; %{pecl_name} extension configuration
; see http://www.php.net/manual/en/yaml.configuration.php
; Decode entities which have the explicit tag "tag:yaml.org,2002:binary"
yaml.decode_binary = 0
; Controls the decoding of "tag:yaml.org,2002:timestamp"
; 0 will not apply any decoding, 1 will use strtotime() 2 will use
date_create().
yaml.decode_timestamp = 0
; Cause canonical form output.
yaml.output_canonical = 0
; Number of spaces to indent sections. Value should be between 1 and 10.
yaml.output_indent = 2
; Set the preferred line width. -1 means unlimited.
yaml.output_width = 80

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.