[Bug 653435] Review Request: perl-Catalyst-Engine-PSGI - PSGI engine for Catalyst

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=653435

--- Comment #7 from Petr Pisar <ppisar at redhat.com> 2011-05-13 09:28:41 EDT ---
Spec file changes:

--- perl-Catalyst-Engine-PSGI.spec 2011-01-14 16:04:43.000000000 +0100
+++ perl-Catalyst-Engine-PSGI.spec.1 2011-05-13 14:41:25.000000000 +0200
@@ -17,47 +17,45 @@
 BuildRequires:  perl(Moose)
 BuildRequires:  perl(Scalar::Util)
 BuildRequires:  perl(URI)
-BuildRequires:  perl(MyApp)
-

 #Tests dependencies:
-BuildRequires:  perl(Plack::Loader)
-BuildRequires:  perl(Test::More)
-BuildRequires:  perl(Test::Requires)
+BuildRequires:  perl(Benchmark)
+BuildRequires:  perl(Catalyst)
+BuildRequires:  perl(Catalyst::Engine::HTTP)
+BuildRequires:  perl(Catalyst::Request)                                        
+BuildRequires:  perl(Catalyst::Request::Upload)                                
+BuildRequires:  perl(Catalyst::Restarter)                                      
+BuildRequires:  perl(Catalyst::Utils)                                          
+BuildRequires:  perl(CGI::Simple::Cookie)                                      
+BuildRequires:  perl(Data::Dumper)                                             
+BuildRequires:  perl(FindBin)                                                  
+BuildRequires:  perl(Getopt::Long)                                             
+BuildRequires:  perl(HTML::Entities)                                           
+BuildRequires:  perl(HTTP::Body::OctetStream)                                  
+BuildRequires:  perl(HTTP::Headers)                                            
+BuildRequires:  perl(HTTP::Headers::Util)                                      
+BuildRequires:  perl(HTTP::Request::Common)                                    
 BuildRequires:  perl(lib)
 BuildRequires:  perl(LWP::UserAgent)
-BuildRequires:  perl(Catalyst)
-BuildRequires:  perl(Catalyst::Utils)
+BuildRequires:  perl(Moose::Role)
 #BuildRequires:  perl(Moose::Utils)
-BuildRequires:  perl(namespace::clean)
 BuildRequires:  perl(MooseX::MethodAttributes)
-BuildRequires:  perl(Moose::Role)
-BuildRequires:  perl(YAML)
-BuildRequires:  perl(HTML::Entities)
-BuildRequires:  perl(Data::Dumper)
 BuildRequires:  perl(MRO::Compat)
-BuildRequires:  perl(FindBin)
-BuildRequires:  perl(Benchmark)
-BuildRequires:  perl(Catalyst::Request)
-BuildRequires:  perl(Catalyst::Request::Upload)
-BuildRequires:  perl(HTTP::Body::OctetStream)
-BuildRequires:  perl(HTTP::Headers)
-BuildRequires:  perl(HTTP::Headers::Util)
-BuildRequires:  perl(HTTP::Request::Common)
+BuildRequires:  perl(namespace::clean)
+BuildRequires:  perl(Params::Util)
 BuildRequires:  perl(Path::Class::Dir)
-BuildRequires:  perl(CGI::Simple::Cookie)
-BuildRequires:  perl(Getopt::Long)
+BuildRequires:  perl(Plack::Loader)
 BuildRequires:  perl(Pod::Usage)
-BuildRequires:  perl(Catalyst::Engine::HTTP)
-BuildRequires:  perl(Catalyst::Restarter)
+BuildRequires:  perl(Test::More)
 BuildRequires:  perl(Test::Pod::Coverage) >= 1.04
+BuildRequires:  perl(Test::Requires)
+BuildRequires:  perl(YAML)

 Requires:       perl(Catalyst::Action::RenderView)
 Requires:       perl(Catalyst::Runtime) >= 5.80007
 Requires:       perl(Filter::Util::Call)

 %{?perl_default_filter}
-%{?perl_default_subpackage_tests}

 %description
 Catalyst::Engine::PSGI is a Catalyst Engine that adapts Catalyst into the PSGI
@@ -66,9 +64,7 @@
 %prep
 %setup -q -n Catalyst-Engine-PSGI-%{version}

-rm -rf inc/Test{More,Requires}.pm
-
-chmod 755 t/*
+rm -rf inc/Test

 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor
@@ -84,10 +80,6 @@
 %check
 make test

-
-%clean
-rm -rf %{buildroot}
-
 %files
 %defattr(-,root,root,-)
 %doc Changes README


Removed BuildRequires:
perl(MyApp)
Ok.

Added BuildRequires:
perl(Params::Util)
TODO: Where is it used? I cannot see that. Remove it.

Other BuildRequires have been reordered only.


TODO: Remove trailing white space from spec file (see the diff output).
TODO: Remove implicit %defattr from %files section.


> FIX: permissions in  perl-Catalyst-Engine-PSGI-tests.noarch
-%{?perl_default_subpackage_tests}
Tests subpackage has been removed. Ok.

All tests pass. Ok.

rpmlint perl-Catalyst-Engine-PSGI.spec
../SRPMS/perl-Catalyst-Engine-PSGI-0.12-1.fc14.src.rpm
../RPMS/noarch/perl-Catalyst-Engine-PSGI-0.12-1.fc14.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint Ok.

Package builds in F16
(http://koji.fedoraproject.org/koji/taskinfo?taskID=3069529). Ok.


Please consider fixing all `TODO' issued before pushing the package into Fedora
repository.
Resolution: Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.