[Bug 704088] Review Request: gcal - GNU Gregorian calendar program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=704088

--- Comment #2 from Daiki Ueno <dueno at redhat.com> 2011-05-16 21:27:41 EDT ---
(In reply to comment #1)

Thank you for the review.

> The binaries in the package are missing man pages, although they have quite
> comprehensive info documentation. Perhaps upstream could be asked to convert
> some of the docs?

The man pages are available in the upstream git repository but not in the
tarballs.  So I included them in the new SRPM.

> $ rpmls gcal-3.6-1.fc15.x86_64.rpm
> [...]
> -rw-r--r--  /usr/share/gcal/CREDITS
> -rw-r--r--  /usr/share/gcal/Makefile.in
> -rw-r--r--  /usr/share/gcal/README
> [...]
> 
> It seems a bit odd that these files are installed under /usr/share - are they
> needed, or can they just be excluded?

Hmm, at least Makefile.in is useless - removed.

> I don't think any of these issues are blocking though, so were I a sponsored
> packager, I would declare this package APPROVED.

Thanks, I'll ask someone to do the formal review - based on your comprehensive
review, it should be quick.

Spec URL: http://ueno.fedorapeople.org/gcal/gcal.spec
SRPM URL: http://ueno.fedorapeople.org/gcal/gcal-3.6-2.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.