[Bug 700551] Review Request: xwax - Open source vinyl emulation software for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700551

--- Comment #5 from John Brier <jbrier at redhat.com> 2011-05-18 18:29:15 EDT ---
(In reply to comment #4)
> Thanks for the new version.  Some more comments:
> 
> - I assume you've added the Requires: line because of the issue mentioned
> regarding decoders?  Normally the automatic checker is sufficient.
Yes, the decoder is only referenced in a bash script so I don't think the
automatic checker would catch it.

> - you need to use macros in the %files section e.g
> 
> %{_bindir}/xwax
> %{_libexecdir}/xwax/xwax-import
> 
> and you should own the %{_libexecdir}/xwax/ directory
> 
> - you don't need the full path for those doc files
> 
> %doc CHANGES COPYING README
> 
> should be enough and you should use macros for the manpage
> 
> %doc %{_mandir}/man1/xwax.1.gz
> 
> 
> To help persuade someone to sponsor you, it would be a good idea to submit a
> couple more new packages and do some informal reviews yourself.

I will look into all of the above. Thanks again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.