[Bug 698692] Review Request: grilo-plugins - Plugins for the Grilo framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698692

--- Comment #6 from Kalev Lember <kalev at smartlink.ee> 2011-05-20 10:21:40 EDT ---
(In reply to comment #4)
> > 1) The BuildRoot tag, the 'rm -rf $RPM_BUILD_ROOT' at the beginning of %install
> > section, the whole %clean section, and the %defattr lines are no longer needed
> > in current Fedora releases and you could remove them, if you want to.
> 
> Done.

I'm just nitpicking here, it's not very important, but ... looks like you
missed the the BuildRoot definition near the top of the spec file and the
%clean section, these can also be removed.


> > 4) The source URL currently looks like this:
[...]
> Pretty much every single GNOME tarball has that exact same problem.

Yeah. If we can figure out a good way to do it, it's something that other GNOME
packages could also use.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.