[Bug 643140] Review Request: autokey - A desktop automation utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=643140

David Timms <dtimms at iinet.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtimms at iinet.net.au

--- Comment #20 from David Timms <dtimms at iinet.net.au> 2011-05-21 19:08:09 EDT ---
Hi Raghu, I'm not a sponsor, but offer the following, mainly regarding
readability:

- Line spacing: I like to see a fixed number of blank lines between each spec
section header. Currently you have either 1 or 2. (I prefer to use 2 so that
each heading stands out, but at least be consistent).

- Use of tabs: in the top part, if you really want to use tabs, then the same
number of tabs should be used between each ':' and value. (Currently there is
some 2x or 1x tab, equating to between 1 and 4 characters spacing).

- Can the package by used command line only ?

- There seems to be no files assigned to the main package. Does that create a
real but no files present package ? Could the -common subpackage instead just
be the main package ?

- As a side note: Upstream mentions it is essentially maintenance only, and
that the most up2date autohotkey compatibility is found with IronAHK. What made
you choose autokey rather than IronAHK for packaging ? 

- If bugs are present in autokey, do you feel that you would be able to tackle
them without upstream support ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.