[Bug 706565] Review Request: sheepdog - The Sheepdog Distributed Storage System for KVM/QEMU

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=706565

--- Comment #5 from Steven Dake <sdake at redhat.com> 2011-05-22 12:29:45 EDT ---
SHOULD (PASS): If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[25]

The license is contained in COPYING

SHOULD (DELAYED): The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
[26]
SHOULD (DELAYED): The reviewer should test that the package builds in mock.
[27]

I will test this on a workday.

SHOULD (DELAYED): The package should compile and build into binary rpms on all
supported architectures. [28]

I will test this on a workday.

SHOULD (delayed until May 25): The reviewer should test that the package
functions as described. A package should not segfault instead of running, for
example.

My test environment is under use until May 25.  May be able to find other
hardware before then.

SHOULD (PASS): If scriptlets are used, those scriptlets must be sane. This is
vague, and left up to the reviewers judgement to determine sanity. [29]

scriptlets are used sanely.
SHOULD (PASS): Usually, subpackages other than devel should require the base
package using a fully versioned dependency. [21]

There are no subpackages.

SHOULD (PASS): The placement of pkgconfig(.pc) files depends on their usecase,
and this is usually for development purposes, so should be placed in a -devel
pkg. A reasonable exception is that the main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb. [30]

There are no pc files.

SHOULD (PASS): If the package has file dependencies outside of /etc, /bin,
/sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the
file instead of the file itself. [31]

All dependencies are accounted for in a clean build environment.

SHOULD (PASS): your package should contain man pages for binaries/scripts. If
it doesn't, work with upstream to add them where they make sense.[32]

There is no man page for the cli tool collie.  sdake will create man page and
submit upstream to sheepdog project, but this is not a blocker.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.