[Bug 707132] Review Request: java-service-wrapper - Java service wrapper

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=707132

--- Comment #4 from Ville Skyttä <ville.skytta at iki.fi> 2011-05-24 15:56:54 EDT ---
(In reply to comment #3)
> With epoch set we effectively enforce use of openjdk.

In my package that was actually the intention.  But I have no problem if you
want to support gcj and this stuff works with it.

> > This results in modifying files in the rpm source dir root, which is not okay.
> No. It is modified in build root. 

No it isn't, you're using "sed -i -e ... %{PATCH1}" which modifies Patch1
in-place in the source dir (the -i argument).

> a) I see nothing wrong on modifying files in buildroot. You can modify what you
> want there.

That's true.  But the file is not modified in the build root, it is modified in
the _source dir_, and this is why a modified patch (already sed'd) ended up in
your source rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.