[Bug 705104] Review Request: freediams - Pharmaceutical Drugs Prescriptor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=705104

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

--- Comment #5 from Volker Fröhlich <volker27 at gmx.at> 2011-05-28 11:41:21 EDT ---
I can't rebuild your source package. Something is wrong with your qmake
options, it seems.

Your package bundles quazip, which is already in Fedora. Please delete it in
the prep section and make your package use the system's version.

Usually the files section starts with the main package and not with a
sub-package.

Harmonize on either using %{buildroot} or $RPM_BUILD_ROOT.

Please pay attention to the translations. See
http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

The description of the data package is wrong. It doesn't contain architecture
independent documentation, but data. Besides that, you should make the
sub-package Noarch, to yield an advantage.

The package includes some tests. Can you run them in a check section?

License and readme file belong to the main package. The install file should not
be included.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.