[Bug 567086] Review Request: VXL - C++ Libraries for Computer Vision Research and Implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567086

--- Comment #20 from Peter Lemenkov <lemenkov at gmail.com> 2011-05-29 10:37:53 EDT ---
Great work!
Unfortunately there are still some remaining issues.

+/- rpmlint is NOT silent:

sulaco ~/Desktop: rpmlint vxl-*
vxl.src:108: W: macro-in-comment %{_docdir}
vxl.src:108: W: macro-in-comment %{name}
vxl.src:109: W: macro-in-comment %{_docdir}
vxl.src:109: W: macro-in-comment %{name}

^^^ these should be ignored (harmless)

vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libbrct.so.1.14.0
exit at GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libvil.so.1.14.0
exit at GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libnetlib.so.1.14.0
exit at GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libv3p_netlib.so.1.14.0
exit at GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libvil1.so.1.14.0
exit at GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libvul.so.1.14.0
exit at GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libvgl_algo.so.1.14.0
exit at GLIBC_2.2.5
vxl.x86_64: W: shared-lib-calls-exit /usr/lib64/libmvl.so.1.14.0
exit at GLIBC_2.2.5

^^^ these ones indicates a flaw in the library's API design (the library
shouldn't call exit but rather return error code to the main application
allowing it to clean up stuff). This is not a blocker (you can't do much here)
but I advise you to notice upstream about this.

vxl.x86_64: W: no-manual-page-for-binary octree

^^^ as said - no man-page for the particular binary. Let's hope that someone
will write this man-page sometime.

vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/Templates/bsta_von_mises+double.3-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vgl/algo/Templates/vgl_orient_box_3d_operators+double-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vgl/Templates/vgl_infinite_line_3d+double-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/bsta_von_mises.h
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vnl/io/Templates/vnl_io_vector_fixed+float.2-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/gel/mrc/vpgl/bgeo/bgeo_sun_pos.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vgl/Templates/vgl_infinite_line_3d+float-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/Templates/bsta_gaussian_sphere+double.2-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vil/Templates/vil_image_view+vil_rgb+bool--.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vgl/algo/Templates/vgl_orient_box_3d_operators+float-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vil/Templates/vil_image_view+vil_rgba+bool--.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vil/Templates/vil_rgb+bool-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/Templates/bsta_von_mises+float.3-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/Templates/bsta_von_mises+double.2-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vgl/Templates/vgl_infinite_line_3d+int-.cxx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/Templates/bsta_von_mises+float.2-.cxx
vxl-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/vxl-1.14.0/contrib/brl/bbas/bsta/bsta_von_mises.txx
vxl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/vxl-1.14.0/core/vgl/vgl_infinite_line_3d.h
vxl-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/vxl-1.14.0/core/vgl/vgl_infinite_line_3d.txx

^^^ Please fix permissions on source files during %prep stage to suppress these
messages.

vxl-devel.x86_64: E: invalid-soname /usr/lib64/libexpat.so libexpat.so

^^^ that sounds like an issue - still no soname for this and several other
libraries. They are *not* a symlinks to the corresponding libraries with a
suffix. Namely:

- libexpat.so
- libmvl2.so
- libvepl2.so

And there is another one possible issue - some libraries have too generic names
(libexpat.so.* and many others) and might interfere with other ones. Could you,
please, put them under dedicated directory? Under something like
%{_libdir}/%{name} (with corresponding /etc/ld.so.conf.d/*.conf file). I'm open
for suggestions here.

vxl-devel.x86_64: W: no-documentation

^^^ may be omitted - we have a separate package for docs.

5 packages and 0 specfiles checked; 3 errors, 31 warnings.
sulaco ~/Desktop: 

- Bundled library - v3p/dcmtk.
- Bundled library - v3p/netlib. This looks pretty hard to fix because netlib
isn't available in Fedora as a whole. instead there are some parts of it
packaged separately. Namely - blas, lapack, f2c and maybe some others. Also it
looks like a licensing nightmare.
- Bundled libraries - contrib/brl/b3p/{expat,expatpp,minizip,shapelib}

- You didn't enable building of v3p/Qv module - is it intentional? I can't find
any licensing details about it. 

- What's the purpose of vcl directory?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.