[Bug 707613] Review Request: dcm4che-test - Test images for dcm4che2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=707613

--- Comment #10 from Mario Ceresa <mrceresa at gmail.com> 2011-05-30 03:41:40 EDT ---
Great work Ankur!

+ koji can correctly build the package
http://koji.fedoraproject.org/koji/taskinfo?taskID=3099815

! rpmlint is *not* silent

[mario at shadow koji]$ rpmlint *.rpm
dcm4che-test.noarch: W: no-documentation

this is ok: we have a separate package for documentation

dcm4che-test.noarch: W: non-conffile-in-etc /etc/maven/fragments/dcm4che-test
dcm4che-test.src: W: invalid-url Source0: dcm4che2-test-2.6.tar.gz

this is ok, the package is taken from svn

dcm4che-test-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java
docs, Java-docs, Avocados

Harmless

dcm4che-test-javadoc.noarch: E: script-without-shebang
/usr/share/javadoc/dcm4che-test/apidocs/javadoc.sh

just add the build root to the find line that you already put in the spec. This
made the trick for me:
find $RPM_BUILD_ROOT%{_javadocdir}/%{name} -name "javadoc.sh" -exec chmod a-x
'{}' \;

3 packages and 0 specfiles checked; 1 errors, 4 warnings.


! md5sum
Still md5sums are different:
477961623e091b2d5f7119f2a69fc1ff  dcm4che2-test-svn-2.6.tar.gz
381ce690ad2c5deff411f79eeea9c1d9  dcm4che2-test-2.6-srpm.tar.gz

Thi is strange, I obtain two different tarballs:

-rw-rw-r--. 1 mario mario 36713364 May 29 21:25 dcm4che2-test-2.6-srpm.tar.gz
-rw-rw-r--. 1 mario mario 36706444 May 30 08:51 dcm4che2-test-svn-2.6.tar.gz

however, after extracting, diff shows no differences:

diff -r dcm4che2-test-2.6-srpm/ dcm4che2-test-svn-2.6/

*puzzled*

So, the package is basically ok: if you don't mind, please repost the srpm with
the changed find line so that the last error in rpmlint disappears.

In the meantime I'll investigate why md5sum outputs differ. It is probably
nothing important or a mistake on my side because the tarballs look identical
with diff.

Best

Mario

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.