[Bug 701347] Review Request: mingw-gtkmm30 - MinGW Windows C++ interface for the GTK+ library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701347

--- Comment #5 from Thomas Sailer <t.sailer at alumni.ethz.ch> 2011-05-30 09:38:28 EDT ---
Fedora review mingw-gtkmm30-3.0.1-2.fc15.src.rpm 2011-05-30

+ OK
! needs attention

Scratch Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3100290

rpmlint:
$ rpmlint mingw-gtkmm30.spec mingw-gtkmm30-3.0.1-2.fc15.src.rpm
mingw32-gtkmm30-debuginfo-3.0.1-2.fc16.noarch.rpm
mingw32-gtkmm30-3.0.1-2.fc16.noarch.rpm
mingw-gtkmm30.src: W: spelling-error %description -l en_US gtkmm 
mingw32-gtkmm30-debuginfo.noarch: E: debuginfo-without-sources
mingw32-gtkmm30.noarch: E: incorrect-fsf-address
/usr/share/doc/mingw32-gtkmm30-3.0.1/COPYING
3 packages and 1 specfiles checked; 2 errors, 1 warnings.

! the fsf address issue should be addressed. Did you or do you know whether the
native package maintainer has contacted upstream?

! rpmlint output
+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the package base name
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
  native Fedora package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  169ed5b088538fa10483177f3035f77c  gtkmm-3.0.1.tar.bz2
  169ed5b088538fa10483177f3035f77c  Download/gtkmm-3.0.1.tar.bz2
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
    Fedora MinGW guidelines allow headers in main package
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
    Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.