[Bug 706984] Review Request: args4j - Small Java lib that makes it easy to parse command line options/args in CUI apps

bugzilla at redhat.com bugzilla at redhat.com
Mon May 30 15:38:28 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=706984

Marek Goldmann <mgoldman at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #11 from Marek Goldmann <mgoldman at redhat.com> 2011-05-30 11:38:27 EDT ---
[x]  License field in the package spec file matches the actual license.

OK, thanks for clarification, specify both licenses then.

[!]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package    : b765c9c25789884cb982e7c8fefc0de0
MD5SUM upstream package: b29f50e3dd5933fb7fe498a38f9fb191

It seems they way you create the package changes the timestamps. Use xz
compression method - change the instructions (and update the file in srpm) to:

# tar cafJ args4j-2.0.16.tar.xz args4j-2.0.16

[x]  If source tarball includes bundled jar/class files these need to be
removed prior to building

Thanks!

[x]  Latest version is packaged.

================
*** APPROVED ***
================

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list