[Bug 706705] Review Request: libmtag-python - Simple python bindings for libmtag music tagging library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=706705

Felipe Contreras <felipe.contreras at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(hdegoede at redhat.c
                   |                            |om)

--- Comment #2 from Felipe Contreras <felipe.contreras at gmail.com> 2011-05-31 18:46:15 EDT ---
(In reply to comment #1)
> ===========
> -package does not meet naming guidelines, python modules should be called
>  python-name rather then name-python, see:
> 
> http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29

Error 503 Service Unavailable

>  So the package (and the specfile) should be named python-libmtag, I realize
>  this contradicts what upstream does, but Fedora names all python modules this
>  way for consistency

Are you sure? There are *a lot* of packages this way:

zinnia-python
xapian-bindings-python
vtk-python
vips-python
vigra-python
util-vserver-python
thunarx-pythonx
telepathy-farsight-python
stfl-python
spice-gtk-python

I could go on.

If I go to the cached page I even see these as examples:
 * gstreamer-python
 * gnome-python2
 * rpm-python

> -There is no clear license info available in the upstream source tarbal, please 
>  ask upstream (I think that may mean asking yourself :) to add a LICENSE file
>  and proper copyright headers to the source files.

Copy LGPL v2.1? Ok.

> -Please include NEWS in the %doc files

Ok.

> -It is ok to include the egginfo file in the Fedora package, see:
> 
> http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns
>  But if you consider it not useful to have it is ok to leave it out too

I don't see the point. I'll leave that out.

Please clarify on the naming scheme, it doesn't seem to be strongly enforced.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.