[Bug 749232] Review Request: nagios-plugins-lcgdm - nagios probes for DPM / LFC nodes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749232

Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |steve.traylen at cern.ch
               Flag|                            |fedora-review?

--- Comment #1 from Steve Traylen <steve.traylen at cern.ch> 2011-11-02 16:22:47 EDT ---
A quick first parse.

Some similar comments to bug #749132.

1) Add details about making the tar ball.
2) CFLAGS
  It seems that Fedora and RHEL6 do have a %{cmake} macro to do all this
  for you. See $(rpm -E '%{cmake}'
  Assuming RHEL5 as well then you can case the dist tag to do it by hand.
  http://fedoraproject.org/wiki/Packaging:DistTag and effectively implement
  the same thing by hand.
3) rpmlint

nagios-plugins-dpm-disk.x86_64: W: only-non-binary-in-usr-lib
nagios-plugins-dpm-head.x86_64: W: only-non-binary-in-usr-lib

   okay this seems to be normal for nagios-plugins even it seems wrong 
   to me, precedent is there so fine.

4) There are directories such as 
   /etc/nrpe.d/
   /usr/lib64/nagios/plugins/lcgdm
   /usr/lib64/nagios/plugins
   /usr/lib64/nagios
    ... 

   that you create but are not part of your package nor owned
   by something you pull in.

   It makes sense as you have done not to require nagios to make
   the probes easily available to other monitoring systems so you should
   at least own the directories.
  
http://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

5) When you require a sub package it should be exactly matched

  Requires: nagios-plugins-lcgdm-common%{?_isa} = %{version}-%{release}

6) You duplicate 
   %doc LICENSE README RELEASE-NOTES
   but they are only needed in just one package with the exception 
   of the LICENSE which should be in all packages that can be installed in
   isolation as defined by the inter requires of your sub packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.