[Bug 726080] Review Request: Xnee - X11 environment recorder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=726080

--- Comment #15 from Martin Gieseking <martin.gieseking at uos.de> 2011-11-02 17:31:03 EDT ---
Hi Matthieu,

here are some additional notes:

- Remove the exec perm from the header files

- You can drop Requires: xnee-libs from the base package and from cnee. The 
  dependency is detected automatically.

- I recommend to replace the call of chrpath with the sed statements given
here:
  http://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath
  chrpath should only be used if none of the preferred methods work

- Change the Group of the libs package to "System Environment/Libraries"

- You can simplify the first rm statement in %install with
  rm -f %{buildroot}%{_libdir}/*.{a,la}
  Your variant is fine as well but in this case it's not necessary to list 
  each file explicitly. 

- Please remove the "Encoding" entry from the .desktop file as it is
deprecated.
  Also, add the missing semicolon after "Utility".

- Either remove "*.h" from %{_includedir}/libxnee/*.h in %files devel, or
  add "%dir %{_includedir}/libxnee/". Otherwise, this directory is unowned and
  won't be removed when you uninstall the package.

- Don't add the doc files (AUTHORS, BUGS, etc.) multiple times. It's sufficient 
  to add them to the base package. The only exception is COPYING. You must
  ensure that the license text of a package gets installed either directly or
  indirectly through a dependent package. Thus, add COPYING to the libs 
  package.

- I suggest to add doc/xnee.pdf as additional %doc to the base package. It 
  contains useful information about the programs and might be helpful for 
  some users.

BTW, do you already have a sponsor? If you're still looking for one, I can
sponsor you. Unfortunately, I'm pretty busy at the moment, so it could take a
couple of days before I find time to have a look at your other packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.