[Bug 749329] Review Request: pcfi - PDF Core Font Information

bugzilla at redhat.com bugzilla at redhat.com
Wed Nov 2 23:33:54 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749329

--- Comment #2 from Severin Gehwolf <sgehwolf at redhat.com> 2011-11-02 19:33:53 EDT ---
Note that this is my first review of a font info package. I'm not sure which
guidelines to follow. Anyhow here are my comments:

1. BuildRoot is not required anymore[1]. Please drop it.
2. URL should be: http://www.adobe.com/devnet/font/#pcfi
3. Perhaps there should be a note that this is repackaging of [2] only
   containing fonts info. Considering this I think it's OK to just use the
   jar on mavencentral.

rpmlint output:
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[1] http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
[2] https://github.com/jukka/pcfi

After the above fixes this package is good to go from my point of view. Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list