[Bug 739417] Review Request: php53-php-gettext - Gettext emulation in PHP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739417

Ankur Sinha <sanjay.ankur at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Ankur Sinha <sanjay.ankur at gmail.com> 2011-11-04 06:35:32 EDT ---
Review:

+ OK
- NA
? Issue

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
- Sources match upstream md5sum:

- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package has a correct %clean section.
+ Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
? No rpmlint output.
[ankur at ankur SRPMS]$ rpmlint php53-php-gettext-1.0.11-3.src.rpm
../SPECS/php53-php-gettext.spec
../RPMS/noarch/php53-php-gettext-1.0.11-3.fc16.noarch.rpm
php53-php-gettext.noarch: E: incorrect-fsf-address
/usr/share/doc/php53-php-gettext-1.0.11/COPYING
php53-php-gettext.noarch: E: incorrect-fsf-address
/usr/share/php/gettext/streams.php
php53-php-gettext.noarch: E: incorrect-fsf-address
/usr/share/php/gettext/gettext.php
php53-php-gettext.noarch: E: incorrect-fsf-address
/usr/share/php/gettext/gettext.inc
2 packages and 1 specfiles checked; 4 errors, 0 warnings.

Please ask upstream to update the address. Not a blocker.

+ final provides and requires are sane:
[ankur at ankur temp]$ review-req-check 
== php53-php-gettext-1.0.11-3.fc16.noarch.rpm ==
Provides:
php-php-gettext = 1.0.11-3.fc16
php53-php-gettext = 1.0.11-3.fc16

Requires:
php53-common  
php53-mbstring  


SHOULD Items:

+ Should build in mock.
+ Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
+ check for outstanding bugs on package. (For core merge reviews)

Issues: None

XXX APPROVED XXX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.