[Bug 711230] Review Request: ruby-rhubarb - simple versioned object-graph persistence for ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711230

Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tcallawa at redhat.com
             Blocks|177841(FE-NEEDSPONSOR)      |
         AssignedTo|nobody at fedoraproject.org    |tcallawa at redhat.com
               Flag|                            |fedora-review+

--- Comment #3 from Tom "spot" Callaway <tcallawa at redhat.com> 2011-11-04 14:18:04 EDT ---
== Review ==

Good:

- rpmlint checks return:
ruby-rhubarb.noarch: W: spelling-error Summary(en_US) versioned -> version ed,
version-ed, version
ruby-rhubarb.src: W: spelling-error Summary(en_US) versioned -> version ed,
version-ed, version
ruby-rhubarb.src:21: W: unversioned-explicit-provides ruby(rhubarb/rhubarb)

All safe to ignore, although, I would strongly recommend that you consider
appending = %{version} to that explicit provides, even if you're not planning
on checking version of it at this time.

- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(288cd1251a41d8daa4dcc081f2f8b65b86eaab246babc3157e0d64eeab552c59)
- package compiles on f16 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Looks good, so APPROVED. Consider versioning that explicit provides before
commit (and, like in the previous review, dropping the Requires: ruby).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.