[Bug 749320] Review Request: xinput_calibrator - A generic touchscreen calibration program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749320

--- Comment #3 from Matthieu Saulnier <casper.le.fantom at gmail.com> 2011-11-04 18:05:29 EDT ---
(In reply to comment #2)
> - I recommend to use the %{version} macro in Source0 in order to simplify 
>   future updates.
Done

> - Add the files Changelog and README to the %docs.
Added

> - Don't add the .gz suffix to the manpage because the compression format 
>   might change. Replace it by an asterisk:
>   %{_mandir}/man1/%{name}.1*
Done

> - Add INSTALL="install -p" to 'make install' so that the timestamps of the 
>   manpage, .desktop file, etc. are preserved.
Added

> - If you plan to build the package for EPEL < 6 as well, you must add a 
>   BuildRoot field, a %clean section and clean the buildroot at the beginning
>   of %install. In case you targeting Fedora and EPEL 6 only, leave everything 
>   as is.
I don't plan to build for EPEL < 6

>   You might want to remove the %defattr line in %files, though. It's 
>   not required for Fedora any longer either.
Removed

Spec URL: http://pingou.fedorapeople.org/RPMs/xinput_calibrator.spec
SRPM URL:
http://pingou.fedorapeople.org/RPMs/xinput_calibrator-0.7.5-2.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.