[Bug 741129] Review Request: OpenStego - Free Steganography solution
bugzilla at redhat.com
bugzilla at redhat.com
Sat Nov 5 14:39:23 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=741129
--- Comment #4 from Martin Gieseking <martin.gieseking at uos.de> 2011-11-05 10:39:22 EDT ---
The package looks almost fine. There are only a few things that have to be
fixed:
- Remove the trailing asterisk from %{_javadocdir}/%{name}/* for proper
directory ownership.
- Add the LICENSE file to the javadoc package, too (with %doc).
- Drop the Encoding entry from the .desktop file, and append a semicolon to
"Categories=System".
$ desktop-file-validate openstego.desktop
openstego.desktop: warning: key "Encoding" in group "Desktop Entry" is
deprecated
openstego.desktop: error: value "System" for string list key "Categories"
in group "Desktop Entry" does not have a semicolon (';') as trailing
character
- As you probably don't want to build this package for EPEL < 6, drop the
BuildRoot field and the %defattr lines.
$ rpmlint /var/lib/mock/fedora-15-x86_64/result/*.rpm
openstego.noarch: W: spelling-error %description -l en_US steganography ->
stenography, stenographer, oceanography
openstego.noarch: W: spelling-error %description -l en_US jpg -> jog, jg, pg
openstego.noarch: W: spelling-error %description -l en_US bmp -> mp, bump, imp
openstego.noarch: W: no-manual-page-for-binary openstego
openstego.src: W: spelling-error %description -l en_US steganography ->
stenography, stenographer, oceanography
openstego.src: W: spelling-error %description -l en_US jpg -> jog, jg, pg
openstego.src: W: spelling-error %description -l en_US bmp -> mp, bump, imp
openstego.src:80: W: macro-in-%changelog %{_javadir}
openstego.src:81: W: macro-in-%changelog %{name}
openstego.src:82: W: macro-in-%changelog %jpackage_script
3 packages and 0 specfiles checked; 0 errors, 10 warnings.
---------------------------------
key:
[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
- GPLv2 according to README
[+] MUST: The License field in the package spec file must match the actual
license.
[X] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
- add the LICENSE file to the javadoc package, too
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum openstego-src-0.5.2.zip*
2c5576c3129ed36b22251c3db97fe85d openstego-src-0.5.2.zip
2c5576c3129ed36b22251c3db97fe85d openstego-src-0.5.2.zip.upstream
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[X] MUST: A package must own all directories that it creates.
%{_javadocdir}/%{name}/ is unowned
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[.] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[+] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[+] MUST: Java packages must BR java-devel and jpackage-utils.
[+] MUST: Java packages must require java and jpackage-utils.
[+] MUST: Bundled binary files (.class, .jar) must be removed in %prep.
EPEL <= 5 only:
[+] MUST: The spec file must contain a valid BuildRoot field.
[X] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.
[X] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.
[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
[+] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[.] SHOULD: Your package should contain man pages for binaries/scripts.
[+] SHOULD: Java applications SHOULD provide a wrapper script in %{_bindir}.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list