[Bug 741129] Review Request: OpenStego - Free Steganography solution

bugzilla at redhat.com bugzilla at redhat.com
Sat Nov 5 20:27:58 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=741129

--- Comment #5 from Matthieu Saulnier <casper.le.fantom at gmail.com> 2011-11-05 16:27:58 EDT ---
(In reply to comment #4)
> - Remove the trailing asterisk from %{_javadocdir}/%{name}/* for proper 
>   directory ownership. 
Removed

> - Add the LICENSE file to the javadoc package, too (with %doc).
Added

> - Drop the Encoding entry from the .desktop file, and append a semicolon to 
>   "Categories=System".
Done

>   $ desktop-file-validate openstego.desktop 
>   openstego.desktop: warning: key "Encoding" in group "Desktop Entry" is 
>   deprecated
>   openstego.desktop: error: value "System" for string list key "Categories" 
>   in group "Desktop Entry" does not have a semicolon (';') as trailing 
>   character
Thanks for this command. I'll use it always now.

> - As you probably don't want to build this package for EPEL < 6, drop the 
>   BuildRoot field and the %defattr lines.
Done

Spec URL: http://fantom.fedorapeople.org/openstego.spec
SRPM URL: http://fantom.fedorapeople.org/openstego-0.5.2-4.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list