[Bug 751564] Review Request: The Aeolus Audrey Startup Agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751564

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2011-11-06 06:24:45 EST ---
Some quick comments:
- Please use _bindir and not app_root.
- python-argparse is not available anymore. The argparse module is part of
plain python.
- You have no defattr, so I'm assuming you want to build for Fedora only.
  Then you can also nuke of %clean and BuildRoot
- Please use mkdir and cp directly like rm too to be consistent.
- The first mkdir is not needed anyway, the second one creates all directories
needed.
- Where come the sources from? Please add a full link.
- extra_release is not needed too. When you want to add an extra_release
sometime in the future, just add a number there (or bump the relase). No need
for "%global extra_release 1".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.