[Bug 678809] Review Request: seeks - A web-search proxy that provides a meta-search engine

Sun Nov 6 12:02:38 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=678809

--- Comment #17 from Pierre-YvesChibon <pingou at pingoured.fr> 2011-11-06 07:02:34 EST ---

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

==== C/C++ ====

[x] : MUST - Header files in -devel subpackage, if present.
[x] : MUST - ldconfig called in %post and %postun if required.
[x] : MUST - Package does not contain any libtool archives (.la)
[x] : MUST - Package does not contains kernel modules.
[x] : MUST - Package contains no static executables.
[x] : MUST - Rpath absent or only used for internal libs.
[x] : MUST - Package is not relocatable.
[!] : MUST - Development .so files in -devel subpackage, if present.
        seeks-0.4.0-0.5.RC2.fc17.i686.rpm :
/usr/lib/seeks/plugins/blocker/libblockerplugin.so
        seeks-0.4.0-0.5.RC2.fc17.i686.rpm :
/usr/lib/seeks/plugins/cf/libcfplugin.so
        seeks-0.4.0-0.5.RC2.fc17.i686.rpm :
/usr/lib/seeks/plugins/httpserv/libseekshttpservplugin.so
        seeks-0.4.0-0.5.RC2.fc17.i686.rpm :
/usr/lib/seeks/plugins/img_websearch/libseeksimgwebsearchplugin.so
        seeks-0.4.0-0.5.RC2.fc17.i686.rpm :
/usr/lib/seeks/plugins/no_tracking/libnotrackingplugin.so
        seeks-0.4.0-0.5.RC2.fc17.i686.rpm :
/usr/lib/seeks/plugins/query_capture/libquerycaptureplugin.so
        seeks-0.4.0-0.5.RC2.fc17.i686.rpm :
/usr/lib/seeks/plugins/udb_service/libudbserviceplugin.so
        seeks-0.4.0-0.5.RC2.fc17.i686.rpm :
/usr/lib/seeks/plugins/uri_capture/liburicaptureplugin.so
        seeks-0.4.0-0.5.RC2.fc17.i686.rpm :
/usr/lib/seeks/plugins/websearch/libseekswebsearchplugin.so
        seeks-0.4.0-0.5.RC2.fc17.i686.rpm :
/usr/lib/seeks/plugins/websearch_api_compat/libseekswebsearchapicompatplugin.so
     The presence of these files have been explained and justified by the
reviewee

==== Generic ====

[x] : MUST - Package is licensed with an open-source compatible license and
meets other legal requirements as defined in the legal section of Packaging
Guidelines.
[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x] : MUST - All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x] : MUST - Package contains no bundled libraries.
[x] : MUST - Changelog in prescribed format.
[x] : MUST - Sources contain only permissible code or content.
[x] : MUST - %config files are marked noreplace or the reason is justified.
[x] : MUST - Each %files section contains %defattr if rpm < 4.4
[x] : MUST - Macros in Summary, %description expandable at SRPM build time.
[x] : MUST - Package requires other packages for directories it uses.
[x] : MUST - Package uses nothing in %doc for runtime.
[x] : MUST - Package is not known to require ExcludeArch.
[x] : MUST - Permissions on files are set properly.
[x] : MUST - Package does not contain duplicates in %files.
[x] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
[x] : MUST - Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the
beginning of %install. (EPEL5)
[x] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x] : MUST - License field in the package spec file matches the actual license.
[x] : MUST - Package consistently uses macros (instead of hard-coded directory
names).
[x] : MUST - Package meets the Packaging Guidelines.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[x] : MUST - No %config files under /usr.
[x] : MUST - Package does not generates any conflict.
[x] : MUST - Package obeys FHS, except libexecdir and /usr/target.
[x] : MUST - Package must own all directories that it creates.
[x] : MUST - Package does not own files or directories owned by other packages.
[x] : MUST - Package installs properly.
[x] : MUST - Requires correct, justified where necessary.
[x] : MUST - Rpmlint output is silent.
      No errors and the warnings have been explained        
        rpmlint seeks-0.4.0-0.5.RC2.fc17.i686.rpm

================================================================================
        seeks.i686: W: spelling-error %description -l en_US hashtable -> hash
table, hash-table, washable
        seeks.i686: W: shared-lib-calls-exit /usr/lib/libseeksutils.so.0.0.0
exit at GLIBC_2.0
        seeks.i686: W: shared-lib-calls-exit /usr/lib/libseekslsh.so.0.0.0
exit at GLIBC_2.0
        seeks.i686: W: shared-lib-calls-exit /usr/lib/libseeksproxy.so.0.0.0
exit at GLIBC_2.0
        seeks.i686: W: shared-lib-calls-exit /usr/lib/libseeksplugins.so.0.0.0
exit at GLIBC_2.0
        seeks.i686: W: devel-file-in-non-devel-package
/usr/lib/seeks/plugins/no_tracking/libnotrackingplugin.so
        seeks.i686: W: devel-file-in-non-devel-package
/usr/lib/seeks/plugins/query_capture/libquerycaptureplugin.so
        seeks.i686: W: devel-file-in-non-devel-package
/usr/lib/seeks/plugins/cf/libcfplugin.so
        seeks.i686: W: devel-file-in-non-devel-package
/usr/lib/seeks/plugins/udb_service/libudbserviceplugin.so
        seeks.i686: W: devel-file-in-non-devel-package
/usr/lib/seeks/plugins/img_websearch/libseeksimgwebsearchplugin.so
        seeks.i686: W: non-standard-uid /var/lib/seeks seeks
        seeks.i686: W: non-standard-gid /var/lib/seeks seeks
        seeks.i686: W: devel-file-in-non-devel-package
/usr/lib/seeks/plugins/uri_capture/liburicaptureplugin.so
        seeks.i686: W: devel-file-in-non-devel-package
/usr/lib/seeks/plugins/websearch/libseekswebsearchplugin.so
        seeks.i686: W: devel-file-in-non-devel-package
/usr/lib/seeks/plugins/blocker/libblockerplugin.so
        seeks.i686: W: devel-file-in-non-devel-package
/usr/lib/seeks/plugins/websearch_api_compat/libseekswebsearchapicompatplugin.so
        seeks.i686: W: non-standard-uid /var/log/seeks seeks
        seeks.i686: W: non-standard-gid /var/log/seeks seeks
        seeks.i686: W: devel-file-in-non-devel-package
/usr/lib/seeks/plugins/httpserv/libseekshttpservplugin.so
        seeks.i686: W: no-manual-page-for-binary test_bqc
        seeks.i686: W: no-manual-page-for-binary gen_mrf_query_160
        seeks.i686: W: no-manual-page-for-binary user_db_ops
        seeks.i686: W: no-manual-page-for-binary test_dbqr_compression
        1 packages and 0 specfiles checked; 0 errors, 23 warnings.

================================================================================

        rpmlint seeks-0.4.0-0.5.RC2.fc17.src.rpm

================================================================================
        seeks.src: W: spelling-error %description -l en_US websearch -> web
search, web-search, searcher
        seeks.src: W: spelling-error %description -l en_US hashtable -> hash
table, hash-table, washable
        1 packages and 0 specfiles checked; 0 errors, 2 warnings.

================================================================================

        rpmlint seeks-debuginfo-0.4.0-0.5.RC2.fc17.i686.rpm

================================================================================
        1 packages and 0 specfiles checked; 0 errors, 0 warnings.

================================================================================

[x] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
        seeks.logrotate :
          MD5SUM this package     : 5fbdf9c327999605b0f124132f27a27d
          MD5SUM upstream package : upstream source not found

/home/pingou/Scripts/python/FedoraReview/src/678809/seeks-0.4.0-RC2.tar.gz :
          MD5SUM this package     : dd80c832f80c34c392be5872239a8d9f
          MD5SUM upstream package : dd80c832f80c34c392be5872239a8d9f
        seeks.service :
          MD5SUM this package     : f9d85023278a6628a61d609bfaf01545
          MD5SUM upstream package : upstream source not found
    You have mentioned being in contact with upstream to try to get these files
into the sources

[x] : MUST - Spec file is legible and written in American English.
[x] : MUST - Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x] : MUST - Package contains a SysV-style init script if in need of one.
[x] : MUST - File names are valid UTF-8.
[x] : SHOULD - Reviewer should test that the package builds in mock.
[-] : SHOULD - If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[x] : SHOULD - Dist tag is present.
[x] : SHOULD - No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x] : SHOULD - Final provides and requires are sane (rpm -q --provides and rpm
-q --requires).
[-] : SHOULD - Package functions as described.
[x] : SHOULD - Package does not include license text files separate from
upstream.
[x] : SHOULD - Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x] : SHOULD - Scriptlets must be sane, if used.
[x] : SHOULD - SourceX / PatchY prefixed with %{name}.
[x] : SHOULD - SourceX is a working URL.
[x] : SHOULD - Description and summary sections in the package spec file
contains translations for supported Non-English languages, if available.
[ ] : SHOULD - Package should compile and build into binary rpms on all
supported architectures.
[-] : SHOULD - %check is present and all tests pass.
[x] : SHOULD - Packages should try to preserve timestamps of original installed
files.
[x] : SHOULD - Spec use %global instead of %define.

Regarding license, I found:
- BSD
  -> lsh/swl/License.txt
  -> proxy/protobuf_export_format/strutil.cc for example
    grep "Redistributions of source code must retain" -iR ./src/*

- AGPLv3+
  -> proxy/configuration_spec.cpp for example
    grep "GNU affero general" -iR ./src/*

- LGPLv2+
  -> utils/tests/ut-miscutils.cpp for example
    grep "GNU Lesser" -iR ./src/*

- GPLv2+
  -> proxy/cgi.cpp for example
    grep "GNU General" -iR ./src/*

- LGPL with restriction -> compatible with GPL v2 and not v3
  -> proxy/pcrs.cpp

The files rmd160 (under utils) kind of worry me as well.

I would like to ask spot to confirm:
 1) that all these license can be used together
 2) that the license tag used is the correct one
 3) that the files rmd160 can be redistributed

Once we have the go from spot, I will approve this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.