[Bug 751564] Review Request: The Aeolus Audrey Startup Agent

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 6 15:51:51 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751564

--- Comment #3 from Jim Meyering <meyering at redhat.com> 2011-11-06 10:51:51 EST ---
Hi again,

I've begun looking at the .py file and my first attempt to elicit --help
output failed.  I ran ./audrey_startup.py --help as non-root from the
source directory and got a stack trace followed by this:

    IOError: [Errno 13] Permission denied: '/var/log/audrey.log'

It'd be nice (at least as long as there's no man page) if there were
a --help option that would print the concise description and list brief
option descriptions.  Typically, --help prints output to stdout (not stderr)
and exits successfully without doing anything else.

Looking through the source, I see there's a --pw=PASSWORD option.
That means if one is specifying a password, it will be visible
via "ps".  It would be better to allow the password to be read
from a file or from a TTY, so that it cannot easily be snooped.

In the sources I see mention of "unittest" support.
Is there an easy way to run those unit tests?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list