[Bug 751564] Review Request: The Aeolus Audrey Startup Agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=751564

--- Comment #13 from Joe VLcek <JVLcek at RedHat.com> 2011-11-08 08:31:41 EST ---
(In reply to comment #12)
> For the record, here's the latest --help output:
> 
> usage: audrey_startup.py [-h] [-e ENDPOINT] [-k OAUTH_KEY] [-s OAUTH_SECRET]
>                          [-p] [-L {DEBUG,INFO,WARNING,ERROR,CRITICAL}]
>                          [--version]
> 
> Audrey Start
> 
> optional arguments:
>   -h, --help            show this help message and exit
>   -e ENDPOINT, --endpoint ENDPOINT
>                         Config Server endpoint url
>   -k OAUTH_KEY, --key OAUTH_KEY
>                         oAuth Key
>   -s OAUTH_SECRET, --secret OAUTH_SECRET
>                         oAuth Secret
>   -p, --pwd             Log and look for configs in pwd
>   -L {DEBUG,INFO,WARNING,ERROR,CRITICAL}, --log_level
> {DEBUG,INFO,WARNING,ERROR,CRITICAL}
>                         Logging Level
> 
> Like --pw=PASSWORD before it, the oauth arguments
> should not be exposed on the command line.
> --------------------------------------
> 
> Also, I see two uses of a hard-coded URL:
> 
>     $ grep 169 audrey_startup.py
>     EC2_USER_DATA_URL = 'http://169.254.169.254/latest/user-data'
>      self.ec2_user_data_url = 'http://169.254.169.254/latest/user-data'
> 
> Obviously the literal URL should appear only once, but the
> real question is whether it should appear at all.
> 
> Shouldn't it be specified via an option?

Thank you Jim.

A bad push merge by Greg Blomquist, resulted in the OAUTH arguments
not being prompted for. I will work with Greg to fix the merge.

The 169 URL is the documented method for accessing AWS EC2 user-data
http://docs.amazonwebservices.com/AWSEC2/latest/UserGuide/index.html?AESDG-chapter-instancedata.html

So I believe it is OK for it to be hard-coded however I agree it
should not be hard-coded twice. I will change this to:

EC2_USER_DATA_URL = 'http://169.254.169.254/latest/user-data'
self.ec2_user_data_url = EC2_USER_DATA_URL

Do you think that would be acceptable?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.