[Bug 741494] Review Request: sugar-pukllanapac - A sliding puzzle game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=741494

Thibault North <thibault.north at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thibault.north at gmail.com

--- Comment #1 from Thibault North <thibault.north at gmail.com> 2011-11-08 09:32:10 EST ---
Output of rpmlint -v:
sugar-pukllanapac.src: I: checking
sugar-pukllanapac.src: W: non-standard-group Sugar/Activities
sugar-pukllanapac.src: I: checking-url
http://wiki.sugarlabs.org/go/Activities/Pukllanapac (timeout 10 seconds)
sugar-pukllanapac.src: I: checking-url
http://download.sugarlabs.org/sources/honey/Pukllanapac/Pukllanapac-7.tar.bz2
(timeout 10 seconds)
sugar-pukllanapac.src: W: file-size-mismatch Pukllanapac-7.tar.bz2 = 27445,
http://download.sugarlabs.org/sources/honey/Pukllanapac/Pukllanapac-7.tar.bz2 =
27117
sugar-pukllanapac.noarch: I: checking
sugar-pukllanapac.noarch: W: non-standard-group Sugar/Activities
sugar-pukllanapac.noarch: I: checking-url
http://wiki.sugarlabs.org/go/Activities/Pukllanapac (timeout 10 seconds)
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

A few comments:
- Upstream source doesn't match the tar archive of the source package
- You can remove the macros for %{__python} and just use python
- gettext is a buildrequire
- defattr is now optional

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.