[Bug 744347] Review Request: python-simpleparse - a parser generator
bugzilla at redhat.com
bugzilla at redhat.com
Tue Nov 8 19:55:42 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=744347
Tomasz Torcz <zdzichu at irc.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #3 from Tomasz Torcz <zdzichu at irc.pl> 2011-11-08 14:55:41 EST ---
I find examples in %doc to be better - easy to find, and after all, those are
examples, not to be dependent on.
Rest of review:
- *pyo and *pyc properly included
- rpmlint silent (apart from wrong spelling suggestion)
- package name is OK
- license OK
- source md5sum matches upstream
- build fine on my machine
- permissions are sane
- macro use is consistent
So, I approve this package. Thanks for packaging.
BTW, my FAS account is "ttorcz".
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list