[Bug 752447] Review Request: plasma-mobile - A Plasma Active mobile workspace
bugzilla at redhat.com
bugzilla at redhat.com
Thu Nov 10 13:47:32 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752447
--- Comment #3 from Jaroslav Reznik <jreznik at redhat.com> 2011-11-10 08:47:32 EST ---
Spec URL:
http://rezza.hofyland.cz/fedora/packages/plasma-mobile/plasma-mobile.spec
SRPM URL:
http://rezza.hofyland.cz/fedora/packages/plasma-mobile/plasma-mobile-0.2-2.fc15.src.rpm
(In reply to comment #1)
> A couple of concerns off the top of my head.
>
> 1. desktop-file-validate %check fails. (I'll attach a patch that fixes it for
> me on f16), upstreamed these fixes already to git.kde.org
Ah, I had these patches locally, forgot to add to SPEC/SRPM - in your patch,
there's still one error, I'll take a look if I can upstream it
> 2. %{_qt4_plugindir}/inputmethods/plasmainputcontextplugin.so
> will get multilib'd, so probably want to make -libs package for this item
Ok, added -libs.
> 3. file /usr/lib64/kde4/imports/org/kde/plasma/mobilecomponents is not owned
> by any package. can probably just recursively own that dir, instead of
> enumerating the items under it.
Fixed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list