[Bug 711313] Review Request: wicd-kde - a Wicd client built on the KDE Development Platform

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711313

Kevin Kofler <kevin at tigcc.ticalc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |
               Flag|                            |fedora-review+

--- Comment #35 from Kevin Kofler <kevin at tigcc.ticalc.org> 2011-11-10 11:35:26 EST ---
Pedantic comment of the day:

> cp ${RPM_BUILD_ROOT}%{_kde4_datadir}/applications/kde4/%{name}.desktop \
>    ${RPM_BUILD_ROOT}%{_kde4_datadir}/autostart/%{name}.desktop

We prefer cp -p (no clobbering of the timestamp) to plain cp. Though in this
case it doesn't matter because the file has already been edited by the
desktop-file-install --add-category command before. So this is only a SHOULD.


So it looks like all the issues found have been addressed. Thanks to everyone
who did preliminary reviews.

The package is APPROVED.

We can now proceed with the sponsoring process. Have you already signed up for
a FAS (Fedora Account System) account? What's your FAS account name?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.