[Bug 752169] Review Request: gnome-shell-theme-zukitwo - The Zukitwo theme for Gnome Shell

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752169

--- Comment #2 from Mattia Meneguzzo <hal8600 at hotmail.it> 2011-11-11 04:51:53 EST ---
(In reply to comment #1)
> I will the review the package, but someone else needs to sponsor you.


Thank you very much!


> Some initial comments.
> 
> Use 3.2 as version, because this is a gnome-3.2 theme
> No need to add the deviantart tag id in release.
> 
> no need to require on gnome-tweak-tool, it is not a hard requirement.


Done.


> Maybe splitting the gnome-shell theme and the gtk themes into separate sub
> packages would be a good idea.
> You should be able to use the gnome-shell theme without the gtk themes
> 
> Let me know what you think


In my opinion, having an only package would be better, because
* the GTK themes and the Gnome Shell theme have been created explicitly to be
used together;
* anyway, one can still choose to apply the GTK themes or the Gnome Shell theme
alone through Gnome Tweak Tool, if he prefers.
But this is only a beginner's point of view. If other reasons exist to prefer
creating separate subpackages, please let me know.

Here are the new spec and SRPM:

Spec URL:
http://dl.dropbox.com/u/39458594/Fedora%20packages/gnome-shell-theme-zukitwo_2/gnome-shell-theme-zukitwo.spec

SRPM URL:
http://dl.dropbox.com/u/39458594/Fedora%20packages/gnome-shell-theme-zukitwo_2/gnome-shell-theme-zukitwo-3.2-1.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.