[Bug 744349] Review Request: python-rtslib - python lib to configure TCM/LIO kernel target

bugzilla at redhat.com bugzilla at redhat.com
Fri Nov 11 12:23:07 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=744349

--- Comment #1 from Tomasz Torcz <zdzichu at irc.pl> 2011-11-11 07:23:07 EST ---
Review follows:

What needs work:
- usual s/define/global
- version in changelog differs from Version:
python-rtslib.noarch: W: incoherent-version-in-changelog 1.9.9-7
['1.99.1.git644eece-7.fc16', '1.99.1.git644eece-7'
- my checkout produces different md5sum, could you check:
7c9c0220bba3773639b3e33ffa8d9d22  ../SOURCES/rtslib-1.99.1.git644eece.tar.gz
ace89d9b619277b52e7bde5760418502  rtslib-1.99.1.git644eece.tar.gz



What's good:
- *pyo, *pyc and egg-info files are properly included
- name is fine (module version)
- license is fine
- all files are owned by package
- macro use is consistent
- it builds
- permissions are fine

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list