[Bug 753577] Review Request: gmsh - finite element grid generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753577

--- Comment #2 from Alexey Vasyukov <vasyukov at gmail.com> 2011-11-14 04:04:10 EST ---
Dan, many thanks for comments.

> - system copy of the ANN library (from the ann package)
> must be used instead of the copy in contrib/ANN

Ok. I'll work on it.

> - sources contains mpeg encoder which is a patented thing

Ok. Got the issue. I'll just remove mpeg - it does not affect core
functionality.

> - contrib/tetgen contains a non-commercial only clause

Metis has also similar non-commercial only clause. I disabled them both in
CMake configure. Is it not enough? Should I remove them completely from
sources?

> - the contrib dir contains stuff that could/should exists as separate packages

Ok. I'll re-check it. Could you advice which packages require attention?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.