[Bug 744339] Review Request: dieharder - Random number generator tester and timer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=744339

Richard Shaw <hobbes1069 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |hobbes1069 at gmail.com
               Flag|                            |fedora-review?

--- Comment #11 from Richard Shaw <hobbes1069 at gmail.com> 2011-11-14 16:50:50 EST ---
Ok, I went ahead and built the package, which was successfuly on my Fedora 15
x86_64 system, so that's good. 

A couple of things:

1. Here's the rpmlint output of the installed package. There's things rpmlint
can catch here that it can't from just checking the package:

$ rpmlint dieharder
dieharder.x86_64: I: enchant-dictionary-not-found en_US
dieharder.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdieharder.so.3.31.1 /usr/lib64/libgslcblas.so.0
dieharder.x86_64: W: shared-lib-calls-exit /usr/lib64/libdieharder.so.3.31.1
exit at GLIBC_2.2.5
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

In this case it caught an unused shared library dependency (see below). This
isn't a showstopper but should be reported upstream. The configure script
probably just needs to be tweaked. 

$ rpmlint -I unused-direct-shlib-dependency
unused-direct-shlib-dependency:
The binary contains unused direct shared library dependencies.  This may
indicate gratuitously bloated linkage; check that the binary has been linked
with the intended shared libraries only.

2. You don't need the "*" glob in %files for %{_bindir}/%{name} since there's
nothing else to glob.

I'll start the full review when I get a chance. Perhaps tonight or tomorrow.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.