[Bug 753577] Review Request: gmsh - finite element grid generator

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 14 22:40:24 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753577

--- Comment #3 from Alexey Vasyukov <vasyukov at gmail.com> 2011-11-14 17:40:23 EST ---
I wrote patches and made some changes to Spec.

Regarding the issues mentioned:
- ANN library - fixed by patch, using system ANN now
- MPEG - disabled just as Tetgen and Metis

Regarding contrib directory. It contains:
- ANN - unmodified ANN - replaced with system copy of ANN
- bamg - modified bamg
- Chaco - modified Chaco
- DiscreteIntegration - separate sub-module of Gmsh itself
- Fl_Tree - modified Fl_Tree widget for FLTK UI
- gmm - unmodified GMM - replaced with system copy of GMM
- kbipack - separate sub-module of Gmsh itself
- MathEx - unmodified MathEx, part of SSCILIB - Fedora does not ship SSCILIB
- Metis - disabled in our build
- mpeg_encode - disabled in our build
- NativeFileChooser - modified NativeFileChooser widget for FLTK UI
- Netgen - modified Netgen
- Tetgen - disabled in our build

Contrib dir summary:
- ANN, gmm - replaced with system copies
- Metis, mpeg_encode, Tetgen - disabled
- DiscreteIntegration, kbipack - sub-modules of Gmsh itself
- bamg, Chaco, Fl_Tree, NativeFileChooser, Netgen - modified, derived works
- MathEx - unmodified, not in Fedora


New spec: http://dl.dropbox.com/u/4532412/RPMS/gmsh.spec
New SRPM: http://dl.dropbox.com/u/4532412/RPMS/gmsh-2.5.0-5.fc16.src.rpm

Summary of changes:
* Mon Nov 14 2011 Alexey Vasyukov <vasyukov at gmail.com> - 2.5.0-5
- Disable MPEG support because of patent issues
- Add patch to use system ANN instead of built-in one
- Add patch to use system GMM instead of built-in one
- Update CMake soname patch to avoid hardcoded numbers

+ rpmlint output (incorrect-fsf-address, spurious-executable-perm,
shared-lib-calls-exit) reported upstream


The questions:

#1 There are 3 'bad' components - MPEG with patent issues plus Tetgen and Metis
with non-commercial only clause. I disabled them now with CMake options. Is it
enough or should I remove support for them completely from sources?

#2 How to deal with contrib dir correctly? I guess, I should package MathEx
(SSCILIB) separately and leave derived works (dirs bamg/, Chaco/, Fl_Tree/,
NativeFileChooser/, Netgen/) in contribs. Is it so?

Any comments and/or suggestions?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list