[Bug 753677] Review Request: gnome-shell-extension-no11y - remove acceblity icon from status area

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753677

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2011-11-15 01:03:18 EST ---
Review:-
+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3514553
+ rpmlint on package gave
gnome-shell-extension-noa11y.noarch: W: no-version-in-last-changelog
gnome-shell-extension-noa11y.noarch: W: invalid-url URL Note
gnome-shell-extension-noa11y.noarch: W: no-documentation
gnome-shell-extension-noa11y.noarch: W: empty-%postun
gnome-shell-extension-noa11y.src: W: no-version-in-last-changelog
gnome-shell-extension-noa11y.src: W: invalid-url URL Note
gnome-shell-extension-noa11y.src: E: invalid-spec-name
gnome-shell-extension-noa11y.src:2: W: mixed-use-of-spaces-and-tabs (spaces:
line 2, tab: line 1)
gnome-shell-extension-noa11y.src: W: invalid-url Source0:
noa11y at hedayaty.gmail.com.tar.gz
2 packages and 0 specfiles checked; 1 errors, 8 warnings.

suggestions:
1) you don't need now following in current active Fedora releases.
%defattr (-,root,root,-)

and in %install
rm -rf %{buildroot}

2) add the version-release information in changelog like
* Sun Nov 13 2011 Amir Hedayaty <hedayaty AT gmail DOT com>- 0-0.1
- Initial package for Fedora

3) you can remove warning mixed-use-of-spaces-and-tabs by using command
sed -e 's|\t| |g' gnome-shell-extension-noa11y.spec

3) I see you have wrong spec file added in srpm. you added
gnome-shell-extension-no11y.spec whereas it should be
gnome-shell-extension-noa11y.spec

4) you don't need %postun in spec file. remove that.

5) Host your tarball on some server and use that download url in URL of spec.


submit a new SPEC and SRPM by fixing above issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.