[Bug 752836] Review Request: perl-Class-Field - Class Field Accessor Generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=752836

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2011-11-15 02:23:40 EST ---
Review:-
+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3514609
+ rpmlint on package gave
perl-Class-Field.src: W: spelling-error %description -l en_US const -> cons,
cont, cost
perl-Class-Field.noarch: W: spelling-error %description -l en_US const -> cons,
cont, cost
+ Source match with upstream as (sha1sum)
908a42ded2f16a5066313a8cd20ed41a6de599b8  Class-Field-0.15.tar.gz
908a42ded2f16a5066313a8cd20ed41a6de599b8  ../SOURCES/Class-Field-0.15.tar.gz
+ Follows packaging guidelines.
+ make test shows
All tests successful.
Files=3, Tests=14,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.08 cusr  0.01
csys =  0.12 CPU)
+ Package  perl-Class-Field-0.15-1.fc17.noarch
  Provides: perl(Class::Field) = 0.15
  Requires: perl >= 0:5.006001 perl(Encode) perl(Exporter) perl(base)
perl(strict) perl(utf8) perl(warnings)


Suggestions:
1) you don't need to specify following
BuildRequires:  perl >= 1:5.6.1

2) For the active fedora releases you can remove following from spec
 a) buildroot
 b) cleaning of buildroot in %install
 c) %clean section
 d) %defattr(-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.