[Bug 754123] Review Request: fedora-review - Tool to automate package reviews

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754123

leigh scott <leigh123linux at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |leigh123linux at googlemail.co
                   |                            |m

--- Comment #1 from leigh scott <leigh123linux at googlemail.com> 2011-11-15 13:11:38 EST ---
You need.

1. remove

BuildRoot:  %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag


2. remove

%clean
rm -rf $RPM_BUILD_ROOT

https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean


3. remove

%defattr(-,root,root,-)

https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.