[Bug 753900] Review Request: abi-compliance-checker - An ABI Compliance Checker

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753900

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2011-11-16 00:22:23 EST ---
Review:-
+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3514557
+ rpmlint on package gave
abi-compliance-checker.src:27: W: rpm-buildroot-usage %prep sed -i
"s,\$PREFIX/share/\$TOOL_SNAME,%{buildroot}%{perl_vendorlib}/\$TOOL_SNAME,g"
Makefile.pl
abi-compliance-checker.noarch: E: zero-length
/usr/share/perl5/vendor_perl/abi-compliance-checker/modules/RulesSrc.xml
abi-compliance-checker.noarch: W: no-manual-page-for-binary
abi-compliance-checker
2 packages and 0 specfiles checked; 1 errors, 2 warnings.
==> looks ok and can be ignored for this package

+ Source match with upstream as (sha1sum)
4fe5ecf074faac8e46a6e8af9ee6a00d9c2470c6  abi-compliance-checker-1.95.9.tar.gz
4fe5ecf074faac8e46a6e8af9ee6a00d9c2470c6 
../SOURCES/abi-compliance-checker-1.95.9.tar.gz
+ Follows packaging guidelines.

Suggestions:
1)license looks to be GPLv2+. Good to ask upstream to add license text in perl
files also.
2) you don't need now in Fedora spec following
%install
rm -rf %{buildroot}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.